This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
FM-168: IPC solidity diamond #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
force-pushed
the
fm-168-ipc-solidity-diamond
branch
from
9eef0c2
to
963e5cf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes consensus-shipyard/ipc#234
Builds on #166
The PR deals with the diamond pattern during the deployment of IPC contracts in genesis. The change is that top level contracts can have facets, which cannot be discovered from the ABI, so they are hardcoded in the Genesis interpreter at the moment. The facets are taken into account as libraries that can have dependencies, and then passed to the top level diamond contracts as constructor arguments.